Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meaningless values for {model_name}_cpl_dt in nuopc.runconfig 1deg_jra55do_iaf #55

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Meaningless values for {model_name}_cpl_dt in nuopc.runconfig 1deg_jra55do_iaf #55

merged 5 commits into from
Jun 20, 2024

Conversation

ezhilsabareesh8
Copy link
Contributor

This PR address #132 by setting meaningless values for {model_name}_cpl_dt in nuopc.runconfig .

@ezhilsabareesh8 ezhilsabareesh8 changed the title Set meaningless values for {model_name}_cpl_dt in nuopc.runconfig Meaningless values for {model_name}_cpl_dt in nuopc.runconfig 1deg_jra55do_iaf Apr 15, 2024
dougiesquire
dougiesquire reviewed Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezhilsabareesh8. I assume you tried a negative number, e.g. -999, and it didn't work (that's my recollection)? Did you look into whether we can add comments?

@ezhilsabareesh8
Copy link
Contributor Author

ezhilsabareesh8 commented Apr 16, 2024 •
edited
Loading

Yes negative numbers cause the ESMF_TimeIntervalSet routine to hang up during execution.

I have added comments in nuopc.runconfig in this commit 533a001

dougiesquire
dougiesquire reviewed Apr 16, 2024
View reviewed changes
nuopc.runconfig Outdated Show resolved Hide resolved
dougiesquire
dougiesquire approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dougiesquire
dougiesquire requested changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could we remove all the additional spaces, e.g. atm_cpl_dt = 99999 #not used. It would nice to have consistent styling across different configs (so that we can do diffs etc) and a single space before the commit is probably simplest

This was referenced May 2, 2024
Merged
Closed
@dougiesquire
Copy link
Collaborator

In the TWG meeting today, we agreed to set ocn_cpl_dt to the coupling timestep and all other <component>_cpl_dt = 99999. We decided this was the clearest approach that still works with stop_option = nsteps. @ezhilsabareesh8 would you be able to update this PR?

@ezhilsabareesh8
Copy link
Contributor Author

In the TWG meeting today, we agreed to set ocn_cpl_dt to the coupling timestep and all other <component>_cpl_dt = 99999. We decided this was the clearest approach that still works with stop_option = nsteps. @ezhilsabareesh8 would you be able to update this PR?

Updated in this commit 5b8acda

minghangli-uni
minghangli-uni reviewed Jun 19, 2024
View reviewed changes
nuopc.runconfig Outdated Show resolved Hide resolved
dougiesquire
dougiesquire approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezhilsabareesh8 et al. LGTM

@dougiesquire
Copy link
Collaborator

Please squash and merge to clean up the commit history

@ezhilsabareesh8 ezhilsabareesh8 merged commit ec5a244 into 1deg_jra55do_iaf Jun 20, 2024
@ezhilsabareesh8 ezhilsabareesh8 deleted the 1deg_jra55do_iaf_iss132 branch August 22, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minghangli-uni minghangli-uni minghangli-uni left review comments

@anton-seaice anton-seaice anton-seaice left review comments

@dougiesquire dougiesquire dougiesquire approved these changes

Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ezhilsabareesh8 @dougiesquire @minghangli-uni @anton-seaice